fix(v2): Fix plugin path resolution #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 71a4667 |
yangshun
suggested changes
May 29, 2020
| @@ -21,7 +22,9 @@ export function initPlugins({ | |||
| // We need to fallback to createRequireFromPath since createRequire is only available in node v12. | |||
| // See: https://nodejs.org/api/modules.html#modules_module_createrequire_filename | |||
| const createRequire = Module.createRequire || Module.createRequireFromPath; | |||
| const pluginRequire = createRequire(context.siteDir); | |||
| const pluginRequire = createRequire( | |||
| join(context.siteDir, '/docusaurus.config.js'), | |||
There was a problem hiding this comment.
Could you import this from the constants file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Actually fix #2825. It seems like
createRequireexpects a path to a nodejs module instead of a folder where thepackage.jsonhappens to live in. The module would bedocusaurus.config.js, which is guaranteed to exist in the root docusaurus project folder.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
@docusaurus/plugin-ideal-image.yarn start, it will fail with the error in Error: Cannot find module '@docusaurus/plugin-ideal-image' #2825.node_modulesand manually apply the fix in this PR.yarn start, it will now succeed.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)