Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): _index docs page does not show a sidebar #2839

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

aeneasr
Copy link
Contributor

@aeneasr aeneasr commented May 29, 2020

Closes #2836

Motivation

See #2836

Have you read the Contributing Guidelines on pull requests?

yes

@aeneasr aeneasr requested a review from yangshun as a code owner May 29, 2020 14:44
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 29, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented May 29, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 415b35f

https://deploy-preview-2839--docusaurus-2.netlify.app

website/docs/docs.md Outdated Show resolved Hide resolved
Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
@aeneasr
Copy link
Contributor Author

aeneasr commented Jun 1, 2020

Thank you for the review, applied!

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@lex111 lex111 changed the title docs: _index docs page does not show a sidebar docs(v2): _index docs page does not show a sidebar Jun 1, 2020
@lex111 lex111 merged commit 7cba7f0 into facebook:master Jun 1, 2020
@lex111
Copy link
Contributor

lex111 commented Jun 1, 2020

@aeneasr thank you!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar hidden when using new docs homePageId feature
5 participants