Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): add missing main landmark for needed pages #2858

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 1, 2020

Motivation

This PR adds missing main elements to fix a11y issue reported by Rocket Validator:

Document must have one main landmark

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added pr: polish This PR adds a very minor behavior improvement that users will enjoy. pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Jun 1, 2020
@lex111 lex111 requested a review from yangshun as a code owner June 1, 2020 10:50
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 1, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit d31aa1f

https://deploy-preview-2858--docusaurus-2.netlify.app

@yangshun yangshun merged commit ae91234 into facebook:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants