refactor(v2): combine nested theme providers into one #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
added
the
pr: polish
|
Deploy preview for docusaurus-2 ready! Built with commit 26305e2 |
|
cc @yangshun |
|
Hey, was wondering, isn't declaring things in Not sure that @yangshun is there a convention to separate clearly theme/public api surface from internal code? |
|
We assume that if something is not documented, it is intended for internal
use then. I think this is a simple and understandable way for end-users.
Although of course they can use the useAnnouncementBar hook, but it’s their
responsibility, not ours.
чт, 4 июн. 2020 г. в 16:23, Sébastien Lorber <notifications@github.com>:
… Hey, was wondering, isn't declaring things in @theme/ exposing things as
"public api"?
Not sure that @theme/hooks/useAnnouncementBar should be exposed imho,
neither for importing or swizzling, it looks more like an implementation
detail to me.
@yangshun <https://github.com/yangshun> is there a convention to separate
clearly theme/public api surface from internal code?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2870 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBUIO5LPJ4YBASL74B4RBLRU6N6RANCNFSM4NRNFMBA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed in the comment, we can merge the provider for an announcement bar and tab choice into single one.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Reload the page, changes (preferences) should be restored.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)