Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): make .nojekyll warning more obvious #2887

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Jun 5, 2020

Motivation

We should make this more obvious and also put it within the "static assets" page.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Netlify

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 5, 2020
@yangshun yangshun added pr: documentation This PR works on the website or other text documents in the repo. and removed CLA Signed Signed Facebook CLA labels Jun 5, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 91b1126

https://deploy-preview-2887--docusaurus-2.netlify.app

@yangshun yangshun merged commit 2d8abe1 into master Jun 5, 2020
@yangshun yangshun deleted the yangshun/nojekyll branch June 5, 2020 02:22
@JoelMarcey
Copy link
Contributor

Thanks @yangshun ! You beat me to it :)

Is this something we could add automatically to the static directory when creating a site? Or do you think that is too heavy handed?

@yangshun
Copy link
Contributor Author

yangshun commented Jun 5, 2020

Good idea! I think we could. Maybe make it a ramp up task for MLH folks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants