fix(v2): absolute Links should be automatically prefixed by baseurl #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith / (because useBaseUrl behavior is buggy and forces relative links to absolute links)
|
Deploy preview for docusaurus-2 ready! Built with commit 20cd2f3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Automatically append the baseUrl to links, but this time only the "safe/absolute ones": "/docs/xyz" => "/baseUrl/docs/xyz"
We should absolutely avoid transforming relative links to absolute ones.
useBaseUrl looks buggy to me and does this: "xyz" => "/baseUrl/xyz"
Related issue: #3136
This is a temporary workaround, we should rather use ReactRouter basename and deprecate useBaseUrl()
Have you read the [Contributing Guidelines on pull requests]
Yes
Test Plan
The broken links should fail CI. We now have some in /docs/search.md for dogfooding
Related PRs
#3107
#3059
#3093