docs(v2): add myself to /team page + add TeamProfileCard component #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: documentation
yangshun
approved these changes
Jul 28, 2020
|
|
||
| export default function TeamProfile({name, children, githubUrl, twitterUrl}) { | ||
| return ( | ||
| <div className="col col--6 margin-bottom--lg"> |
There was a problem hiding this comment.
I think the card shouldn't contain the col classes for better reusability. Col classes should remain in the parent class.
There was a problem hiding this comment.
thanks, totally missed that but totally agree :)
Good related blog post: https://visly.app/blog/layout-isolated-components
|
Deploy preview for docusaurus-2 ready! Built with commit 4e23551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm on the team now 🤪