Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(v2): prepare v2.0.0.alpha-60 release #3154

Merged
merged 3 commits into from
Jul 29, 2020
Merged

chore(v2): prepare v2.0.0.alpha-60 release #3154

merged 3 commits into from
Jul 29, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 29, 2020

Motivation

Release v2.0.0.alpha-60

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

@slorber slorber requested a review from yangshun as a code owner July 29, 2020 15:08
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jul 29, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 29, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 29, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit 87fa27f

https://deploy-preview-3154--docusaurus-2.netlify.app

@slorber slorber requested a review from lex111 as a code owner July 29, 2020 15:22
yangshun
yangshun approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Typically when I release hotfix/versions too close to each other I'd delete the previous docs so as to not clutter the versioned docs when there aren't too many differences between versions.

@slorber slorber merged commit 1083454 into master Jul 29, 2020
@slorber
Copy link
Collaborator Author

slorber commented Jul 29, 2020

Ah I see, will do in another PR :)

@yangshun yangshun deleted the slorber/alpha60 branch July 29, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slorber @docusaurus-bot @yangshun @facebook-github-bot