Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): inability for users to pin their docusaurus version #3162

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

BuckyMaler
Copy link
Contributor

Motivation

These changes allow users to pin their version of Docusaurus. If a users package.json had the following:

"dependencies": {
  "@docusaurus/core": "2.0.0-alpha.59",
  "@docusaurus/preset-classic": "2.0.0-alpha.59",
  ...
}

They'd expect the version of all @docusaurus packages to be 2.0.0-alpha.59, but that's not the case because for example packages/docusaurus/package.json has "@docusaurus/types": "^2.0.0-alpha.59" and because of the caret version range 2.0.0-alpha.60 of @docusaurus/types is installed.

Have you read the Contributing Guidelines on pull requests?

Yes

Closes #3161

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 30, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit e4d2ec7

https://deploy-preview-3162--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Jul 30, 2020

I see, so the problem is transitive dependencies might use a newer incompatible version, makes sense thanks

@slorber slorber changed the title fix: inability for users to pin their docusaurus version fix(v2): inability for users to pin their docusaurus version Jul 30, 2020
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 30, 2020
@slorber slorber merged commit e9a2b1d into facebook:master Jul 30, 2020
@BuckyMaler BuckyMaler deleted the pin-docusaurus-versions branch July 30, 2020 15:03
@slorber
Copy link
Collaborator

slorber commented Aug 31, 2020

Unfortunately this feature keeps being removed, as Lerna publish does add the ^ back :(

@BuckyMaler
Copy link
Contributor Author

Lerna has an exact option for its version command and it seems it could be useful for publish if used in lerna.json.

lerna/lerna#2397 (comment)

@slorber
Copy link
Collaborator

slorber commented Sep 1, 2020

Thanks,

Related to:
#3386
#3371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versions cannot be pinned as expected
4 participants