Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): fix link items refusing attributes like target, rel etc... #3168

Merged
merged 1 commit into from
Jul 30, 2020
Merged

fix(v2): fix link items refusing attributes like target, rel etc... #3168

merged 1 commit into from
Jul 30, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 30, 2020

Motivation

#3159

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 30, 2020
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 30, 2020
@slorber slorber linked an issue Jul 30, 2020 that may be closed by this pull request
v2: facebook template not working #3159
Closed
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 38d37fe

https://deploy-preview-3168--docusaurus-2.netlify.app

yangshun
yangshun approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@slorber slorber merged commit 68f4bd0 into master Jul 30, 2020
@slorber slorber deleted the slorber/footer-link-items-allow-unknown-attributes branch July 30, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2: facebook template not working
4 participants
@slorber @docusaurus-bot @yangshun @facebook-github-bot