Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): doc path special char (space or other) should lead to a valid slug #3262

Merged
merged 3 commits into from
Aug 11, 2020
Merged

fix(v2): doc path special char (space or other) should lead to a valid slug #3262

merged 3 commits into from
Aug 11, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 11, 2020

Motivation

Fixes #3223

Test Plan

tests

@slorber slorber requested a review from yangshun as a code owner August 11, 2020 14:30
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 11, 2020
@slorber slorber added pr: bug fix This PR fixes a bug in a past release. and removed CLA Signed Signed Facebook CLA labels Aug 11, 2020
@slorber slorber mentioned this pull request Aug 11, 2020
Closed
@slorber slorber added the CLA Signed Signed Facebook CLA label Aug 11, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit d1ed622

https://deploy-preview-3262--docusaurus-2.netlify.app

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit b9ff956

https://deploy-preview-3262--docusaurus-2.netlify.app

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 663deab

https://deploy-preview-3262--docusaurus-2.netlify.app

@slorber slorber merged commit dd3f3f1 into master Aug 11, 2020
@slorber slorber deleted the slorber/doc-slug-support-special-chars branch August 11, 2020 16:37
@banli17
Copy link

banli17 commented Aug 27, 2020 •
edited
Loading

@slorber Error: Unable to resolve valid document slug. Maybe your slug frontmatter is incorrect? Doc id=node原理与解析 / dirName=node / frontmatterSlug=undefined => bad result slug=/node/node原理与解析

@slorber
Copy link
Collaborator Author

slorber commented Aug 27, 2020

Hi @banli17

Can you open another issue for that?

I don't know much about chars like 原理与解析, are theese valid pathname characters? What do you expect the slug to be according to this id/filename?

As an escape hatch you can write your own slug with the slug frontmatter

@slorber
Copy link
Collaborator Author

slorber commented Aug 27, 2020

Note @banli17 this PR is not yet released. Please tell me if the upcoming release does not fix your issue, but I think it will.

Probably releasing next week

@MaHe666
Copy link

MaHe666 commented Mar 28, 2023

There is a bug when I use character #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun Awaiting requested review from yangshun

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

54 -> 61 no longer supports spaces in Doc Folder names
5 participants
@slorber @docusaurus-bot @banli17 @MaHe666 @facebook-github-bot