Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): ability to add/override theme html metadatas #3406

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 4, 2020

Motivation

Generic way to add/override some theme metadatas without swizzling the layout

I particular, ability to override the default value we set for twitter:card

module.exports = {
  // ...
  themeConfig: {
    metadatas: [{name: 'twitter:card', content: 'summary'}],
    // ...
  },
};

fixes #3024

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 4, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 4, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 0b11a4d

https://deploy-preview-3406--docusaurus-2.netlify.app

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Sep 4, 2020
@slorber slorber merged commit 2185294 into master Sep 4, 2020
@lex111 lex111 deleted the slorber/themeConfig.metadatas branch October 7, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External previews of Docusaurus links are inconsistent
3 participants