Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add beforeDefaultRemarkPlugins/beforeDefaultRehypePlugins options to all md content plugins #3467

Merged

Conversation

ayshiff
Copy link
Contributor

@ayshiff ayshiff commented Sep 19, 2020

Motivation

Closes #3437

This PR fixes the use of the options beforeDefaultRemarkPlugins and beforeDefaultRehypePlugins inside plugin-content-docs and plugin-content-bloc (the options were not loaded in the @docusaurus/mdx-loader).
It also adds these options for the plugin plugin-content-pages.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I would like some help on how to test if my code is working correctly.
Theoretically it should work but I would like to be able to test it with a real scenario.

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 19, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 19, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit a8c3e23

https://deploy-preview-3467--docusaurus-2.netlify.app

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, but I wonder how this parameter was already specified in pluginOptionScheme file of blog plugin?

beforeDefaultRemarkPlugins: RemarkPluginsSchema.default(

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Sep 29, 2020
@slorber
Copy link
Collaborator

slorber commented Sep 29, 2020

LGTM thanks! will make it consistent across the 3 plugins

@slorber slorber changed the title feat(v2): Allow overriding remark-rehype plugins feat(v2): add beforeDefaultRemarkPlugins/beforeDefaultRehypePlugins options to all md content plugins Sep 29, 2020
@slorber slorber merged commit d3a0145 into facebook:master Sep 29, 2020
@lex111 lex111 added this to the v2.0.0-alpha.65 milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2: allow overriding default remark plugins in content-docs
5 participants