fix(v1): v1 deploy preview should be available #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 308528e |
lex111
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
It works perfectly! https://deploy-preview-3517--docusaurus-2.netlify.app/v1
|
Great :) plan to add the The scripts will need some refactoring though (as the Netlify site use v2 site as root dir, a bit confusing) but this can be done later |
|
New deploy preview for the v1 site migrated to v2 with the cli: https://deploy-preview-3517--docusaurus-2.netlify.app/v1-migrated/ Adds 90sec to Netlify deploy time, seems acceptable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A simple v1 deploy preview should be available to review v1 PRs.
As we have multiple deploy previews now we can more easily include v1.
With only English, and only a minimal amount of version it does not increase deploy preview time significantly