Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docusaurus v2 Showcase #3645

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Update Docusaurus v2 Showcase #3645

merged 2 commits into from
Oct 27, 2020

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Oct 27, 2020

Motivation

Just wanted to add https://next-auth.js.org to the showcase as I believe it to be a particularly nice implementation of Docusaurus.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Only changed docs / showcase.md page

Related PRs

N/A

@facebook-github-bot
Copy link
Contributor

Hi @ndom91!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 90d0803

https://deploy-preview-3645--docusaurus-2.netlify.app

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looking website!

@lex111
Copy link
Contributor

lex111 commented Oct 27, 2020

@ndom91 could you please sign the required CLA?

@ndom91
Copy link
Contributor Author

ndom91 commented Oct 27, 2020

@lex111 I just signed it after submitting the PR, according to that page it should update automatically shortly, right? I did signin with my Github account during the CLA signing flow.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 27, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111 lex111 merged commit d9bfe84 into facebook:master Oct 27, 2020
@lex111
Copy link
Contributor

lex111 commented Oct 27, 2020

@ndom91 thanks! But you are using an old (unsupported) version, so we recommend that you upgrade to the latest one.

@ndom91
Copy link
Contributor Author

ndom91 commented Oct 27, 2020

An old supported version of what?

@lex111
Copy link
Contributor

lex111 commented Oct 27, 2020

Docusaurus, of course. We are still in the alpha stage, so we often release new versions that contain many different improvements and bug fixes. Therefore, it is important to update to the latest versions as soon as they become available.

@ndom91
Copy link
Contributor Author

ndom91 commented Oct 27, 2020

Ah gotcha, good call. I'll do that.

@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants