Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(v2): deployment should use mdx extension #3699

Merged
merged 4 commits into from
Nov 5, 2020
Merged

docs(v2): deployment should use mdx extension #3699

merged 4 commits into from
Nov 5, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Nov 5, 2020 •
edited
Loading

Motivation

  • it uses <Tabs/>
  • Prettier does not format correctly .md extensions containing too much JSX
  • IDE syntax highlighting is broken
  • My i18n PR fails due to Crowdin doing weird interpretations of this markup

I prefer to change it in upstream branch to avoid conflicts later.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 5, 2020
@slorber slorber added pr: documentation This PR works on the website or other text documents in the repo. and removed CLA Signed Signed Facebook CLA labels Nov 5, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 5, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit e0aad95

https://deploy-preview-3699--docusaurus-2.netlify.app

@slorber slorber added the CLA Signed Signed Facebook CLA label Nov 5, 2020
@slorber slorber merged commit c22c132 into master Nov 5, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
@slorber slorber deleted the slorber/fix-deployment-doc-mdx branch August 17, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
v2.0.0-alpha.68
Development

Successfully merging this pull request may close these issues.
4 participants
@slorber @docusaurus-bot @lex111 @facebook-github-bot