i18n: use zh-TW and zh-CN over zh-Hant and zh-Hans #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both crowdin and docsearch i18n configs use TW and CN over Hant and Hans. This should reduce some config confusions. cc @ericnakagawa. Also, apparently you're working on algolia search i18n?
chenglou
commented
Jan 6, 2018
| @@ -41,8 +41,8 @@ files: | |||
| 'tr': 'tr' | |||
| 'uk': 'uk' | |||
| 'vi': 'vi' | |||
| 'zh-CN': 'zh-Hans' | |||
| 'zh-TW': 'zh-Hant' | |||
| 'zh-CN': 'zh-CN' | |||
There was a problem hiding this comment.
I hope this and the changes in website/ don't break docusaurus's own site's current crowdin settings. There's no chinese translation for it right now anyway.
|
@chenglou Thanks! This seems reasonable to me. We will know after I merge this whether |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both crowdin and docsearch i18n configs use TW and CN over Hant and Hans. This should reduce some config confusions.
cc @ericnakagawa. Also, apparently you're working on algolia search i18n?