Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): ensure publishConfig.access presence with tests #3786

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Nov 19, 2020

Motivation

Tests to ensure that all our packages starting with @ will have the required publishConfig.access: "public" in package.json, otherwise these packages will fail to publish on lerna publish, and lead to restarting the release on a new version.

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Nov 19, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 19, 2020
@slorber slorber added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. and removed pr: bug fix This PR fixes a bug in a past release. labels Nov 19, 2020
@netlify
Copy link

netlify bot commented Nov 19, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 3dcae7b

https://deploy-preview-3786--docusaurus-2.netlify.app

@github-actions
Copy link

Size Change: +18 B (0%)

Total Size: 153 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -1 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.86 kB +1 B
website/build/main.********.js 109 kB +18 B (0%)
website/build/styles.********.css 17.3 kB 0 B

compressed-size-action

@slorber slorber merged commit 04f307c into master Nov 19, 2020
@lex111 lex111 added this to the v2.0.0-alpha.69 milestone Nov 23, 2020
@slorber slorber deleted the slorber/ensure-publishConfig branch August 17, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants