Adds createRequire for preset resolution #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit acad15e |
|
Thanks, looks safe to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cf #2576 (comment)
Have you read the Contributing Guidelines on pull requests?
Yep
Test Plan
Made the changes locally, things worked. Would be difficult for me to automate the test, as it's usually very infra-specific (for instance I'd install the project with Yarn 2, but it would require to make that possible in the test framework, and that's outside of my scope).
Related PRs
#2789 added the same thing for plugins, but forgot presets (or perhaps they didn't exist at the time), cc @SamChou19815