-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): add baseUrlIssueBanner configuration to disable banner #3802
Conversation
Deploy preview for docusaurus-2 ready! Built with commit 130e211 |
Size Change: +190 B (0%) Total Size: 154 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some nits below.
packages/docusaurus/src/client/baseUrlIssueBanner/BaseUrlIssueBanner.tsx
Outdated
Show resolved
Hide resolved
@slorber thanks! |
*/ | ||
|
||
.baseUrlIssueBanner { | ||
display: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious as to why this was hidden from view? Getting this error and it never showed which caused me to come here :/
This is hidden on purpose because if the css can load it means baseurl is
correctly configured.
It's not clear to me what error you have exactly
Le mer. 23 déc. 2020 à 17:17, Alec Brunelle <notifications@github.com> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In packages/docusaurus/src/client/baseUrlIssueBanner/styles.module.css
<#3802 (comment)>:
> @@ -0,0 +1,10 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+.baseUrlIssueBanner {
+ display: none;
Curious as to why this was hidden from view? Getting this error and it
never showed which caused me to come here :/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3802 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW6PT7S6SZ4UKH2IITGOTSWIJ2VANCNFSM4T7XR6QQ>
.
|
Motivation
Better naming refactor + add option to disable the baseUrl help banner.
This banner is not compatible with users with strict CSP policies (#3584 (comment))