Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): Allow footer logo at attribute to be empty #3817

Merged
merged 1 commit into from
Nov 25, 2020
Merged

fix(v2): Allow footer logo at attribute to be empty #3817

merged 1 commit into from
Nov 25, 2020

Conversation

aarongarciah
Copy link
Contributor

Motivation

Enable the footer logo to have an empty alt="" attribute. Basically, the same that #3352 did for the navbar logo but now for the footer.

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Img#Attributes

Setting this attribute to an empty string (alt="") indicates that this image is not a key part of the content (it’s decoration or a tracking pixel), and that non-visual browsers may omit it from rendering.

Since the logo normally is decorative an empty alt is fine.

Fixes #3816

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  1. Run unit tests.
  2. Create a new project and set the footer.logo.alt option in the Docusaurus config file to '' (alt: '')
  3. yarn start and check that Docusaurus doesn't complain about footer.logo.alt being empty.

@facebook-github-bot
Copy link
Contributor

Hi @aarongarciah!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Nov 25, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 25, 2020

LGTM thanks :)

don't forget to sign the CLA, will merge when the CI checks pass

@netlify
Copy link

netlify bot commented Nov 25, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 689d200

https://deploy-preview-3817--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 25, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"footer.logo.alt" is not allowed to be empty
3 participants