-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(V2): add custom wrapper class to SearchPage, fix title #3834
Conversation
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 2e73641 |
Hi, PR should pass after updating your branch, it's an error on master I fixed |
8750f4a
to
2246073
Compare
@@ -294,7 +294,7 @@ function Search() { | |||
}, [searchValue]); | |||
|
|||
return ( | |||
<Layout title={getTitle()}> | |||
<Layout title={getTitle()} wrapperClassName="search-results-wrapper"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
search-page-wrapper
is better suited because "results" can only refer to a specific section of this page.
I have decided also to add small fix for the title of the Currently the page title do not follow the general pattern which includes
Preview |
@Simek thanks! |
Motivation
Currently there is not possible to customize the
SearchPage
styling without swizzling the component.This PR adds the custom wrapper class name to the
SearchPage
, so it will be possible to add custom styles which only apply to this page.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Local run of Docusaurus V2 website.
Preview
Related PRs
No.