Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): improve Footer structure, add class names, use Infima transition #3882

Merged

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Dec 4, 2020

Motivation

This PR includes few small improvements to the theme-classic Footer component:

  • add distinctive classNames for copyright element and bottom content wrapper to allow easier Footer customization
  • do not render empty copyright element when there is no copyright specified
  • use default values from Infima for logo transition delay and function

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Local build and run of v2 website.

HTML preview

Screenshot 2020-12-04 182901

Related PRs

No.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 4, 2020
@github-actions
Copy link

github-actions bot commented Dec 4, 2020

Size Change: +18 B (0%)

Total Size: 157 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -1 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.84 kB -2 B (0%)
website/build/main.********.js 113 kB +21 B (0%)
website/build/styles.********.css 17.5 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Dec 4, 2020

✔️ Deploy preview for docusaurus-2 ready!
Built without sensitive environment variables

🔨 Explore the source changes: f77c753

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fca6df721284800074259a1

😎 Browse the preview: https://deploy-preview-3882--docusaurus-2.netlify.app

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 7, 2020
@slorber
Copy link
Collaborator

slorber commented Dec 7, 2020

thanks 👍

@slorber slorber merged commit e00e54a into facebook:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants