docs(v2): Wrap section about custom domains in :::info #3891
Conversation
|
Hi @Alex1304! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Size Change: 0 B Total Size: 154 kB ℹ️ View Unchanged
|
|
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: 18eb95a 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fce62fe9e9d790008580a29 😎 Browse the preview: https://deploy-preview-3891--docusaurus-2.netlify.app |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
slorber
changed the title
slorber
added
the
pr: documentation
|
thanks 👍 |
Motivation
Yesterday I reported #3889 because I believed that a bug in Docusaurus was erasing my custom domain from the repository settings on each deploy. Turns out the issue was as simple as the fact that I forgot to add a CNAME file, I for some reason completely missed the section telling to add CNAME at the root of the
static/directory. That being said, I believe the issue could have been avoided if this section was put more in evidence, hence the idea of wrapping the section in an:::infoblock.Have you read the Contributing Guidelines on pull requests?
Yes
Related issues
#3889