Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): do not treat at-rules during CSS minification #3896

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Dec 8, 2020

Motivation

Fixes #3836

This disables the removeUnusedAtRules option in advanced CSS minifier as it does not work correctly for us.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tested on https://github.com/semoal/docusaurus-css-minifier-bug (after that, the building of site goes without fatal errors).

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Dec 8, 2020
@lex111 lex111 requested a review from slorber as a code owner December 8, 2020 15:38
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 8, 2020
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, strange that it does not work but we'd rather disable this for now

@github-actions
Copy link

github-actions bot commented Dec 8, 2020

Size Change: 0 B

Total Size: 154 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.82 kB 0 B
website/build/main.********.js 109 kB 0 B
website/build/styles.********.css 17.5 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Dec 8, 2020

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: 895e18c

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fcf9dfe640fb8000715789a

😎 Browse the preview: https://deploy-preview-3896--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 8, 2020

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 82
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3896--docusaurus-2.netlify.app/classic/

@lex111 lex111 merged commit b14b9c8 into master Dec 8, 2020
@lex111 lex111 deleted the lex111/iss3836 branch December 8, 2020 15:53
@bravo-kernel
Copy link
Contributor

Confirmed same issue, hope this gets released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] - CSS minifier crash the build due to fonts
4 participants