-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): add FoalTS to showcase page #3928
Conversation
Hi @LoicPoullain! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Size Change: +19 B (0%) Total Size: 152 kB ℹ️ View Unchanged
|
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: 898e07f 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fda1eb3922867000793dfb9 😎 Browse the preview: https://deploy-preview-3928--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3928--docusaurus-2.netlify.app/classic/ |
Thanks @LoicPoullain , that looks great can you sign the CLA please? I can't merge without it |
Hmm, this is weird. I signed it 10-15minutes. I'll try again. |
I've signed again. Maybe there's a lot of traffic now.
|
yes sometimes the bot takes time :) will wait and see thanks |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Motivation
The documentation of FoalTS has migrated from Gitbook to Docusaurus v2. It could be great to add it in the showcase page.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run
yarn run start:v2
and check that the pagehttp://localhost:3000/showcase
is rendered properly.Related PRs
No docs to update.