Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): blog.md with docs: false, for blog-only mode #3931

Merged
merged 1 commit into from
Dec 17, 2020
Merged

docs(v2): blog.md with docs: false, for blog-only mode #3931

merged 1 commit into from
Dec 17, 2020

Conversation

Romstar
Copy link
Contributor

@Romstar Romstar commented Dec 17, 2020

Added docs: false, to the config for blog-only mode because we do not want any documents if we're in blog-only mode otherwise, we probably wouldn't use blog-only mode.

Motivation

To setup only a blog with Docusaurs v2.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Added ***docs: false,*** to the config for blog-only mode because we do not want any documents if we're in blog-only mode otherwise, we probably wouldn't use blog-only mode.
@facebook-github-bot
Copy link
Contributor

Hi @Romstar!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Dec 17, 2020

✔️ Deploy preview for docusaurus-2 ready!
Built without sensitive environment variables

🔨 Explore the source changes: 27e737b

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fdb915a2646c20008083284

😎 Browse the preview: https://deploy-preview-3931--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3931--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

Size Change: +20 B (0%)

Total Size: 152 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB +1 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.8 kB -1 B
website/build/main.********.js 108 kB +20 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 17, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 17, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber
Copy link
Collaborator

slorber commented Dec 17, 2020

Thanks

@slorber slorber changed the title Update blog.md with docs: false, for blog-only mode docs(v2): blog.md with docs: false, for blog-only mode Dec 17, 2020
@slorber slorber merged commit 5757cdc into facebook:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants