Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix i18n build logging. #3941

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Dec 18, 2020

Motivation

We shouldn't print "run npm serve" more than once:

image

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 18, 2020
@slorber slorber requested a review from lex111 as a code owner December 18, 2020 18:37
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 18, 2020
@github-actions
Copy link

Size Change: 0 B

Total Size: 155 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.81 kB 0 B
website/build/main.********.js 111 kB 0 B
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Dec 18, 2020

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: 39bcf38

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fdcf6fae0095000071adc46

😎 Browse the preview: https://deploy-preview-3941--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 65
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3941--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit b133e2d into master Dec 18, 2020
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/better-i18n-build-logging branch August 17, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants