Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix svg loader for CSS files #3965

Merged
merged 3 commits into from
Dec 29, 2020
Merged

Conversation

apurvaojas
Copy link
Contributor

@apurvaojas apurvaojas commented Dec 29, 2020

Motivation

Fixes SVG used in CSS

fix #3964

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 29, 2020
@netlify
Copy link

netlify bot commented Dec 29, 2020

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: dabc9de

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5feb0b916e716f00082a478d

😎 Browse the preview: https://deploy-preview-3965--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 29, 2020

Size Change: +12 B (0%)

Total Size: 155 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB +1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.82 kB +3 B (0%)
website/build/main.********.js 111 kB +8 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Dec 29, 2020

Thanks @apurvaojas

Your code does not pass CI checks and breaks other things, but will edit your PR and merge this useful fix.
TIL about the issuer attribute ;)

@slorber slorber changed the title bug(v2): fix svg loader for styles re #3964 fix(v2): fix svg loader for CSS files Dec 29, 2020
@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3965--docusaurus-2.netlify.app/classic/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 29, 2020
@slorber slorber merged commit 5944226 into facebook:master Dec 29, 2020
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS/SCSS relative path SVG image not loading
4 participants