Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add AI-Speaker site to showcase page #3976

Merged
merged 3 commits into from
Dec 30, 2020

Conversation

asystentka-jolka
Copy link
Contributor

Motivation

The documentation of AI-Speaker is using Docusaurus v2. It could be cool to add it in the showcase page.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.

Related PRs

No

@facebook-github-bot
Copy link
Contributor

Hi @asystentka-jolka!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Dec 30, 2020

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: b5e4079

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fec9cc80cde110007dcc494

😎 Browse the preview: https://deploy-preview-3976--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 30, 2020

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 82
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3976--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Dec 30, 2020

Size Change: +12 B (0%)

Total Size: 155 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB +2 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.82 kB +2 B (0%)
website/build/main.********.js 111 kB +8 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 30, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 30, 2020
@slorber slorber changed the title Add the documentation of AI-Speaker site to showcase page docs(v2): Add AI-Speaker site to showcase page Dec 30, 2020
@slorber
Copy link
Collaborator

slorber commented Dec 30, 2020

thanks, LGTM 👍

The CI issue is just due to prettier formatting, will fix this

@slorber slorber merged commit a0c5177 into facebook:master Dec 30, 2020
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants