Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(v2): nudge users to add site to showcase #3977

Merged
merged 1 commit into from
Dec 30, 2020
Merged

docs(v2): nudge users to add site to showcase #3977

merged 1 commit into from
Dec 30, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Dec 30, 2020

Motivation

It's not so easy for users to add their site.

This PR:

  • Add a "Add your site!" button
  • Add better instructions to add a Docusaurus site to showcase
  • ignore prettier formatting errors (as edits are often done through Github interface)

image

image

@slorber
Showcase:
61dc4e7 
- Add a "Add your site!" button
- Add instructions to add a Docusaurus site to showcase
- ignore prettier formatting errors (as edits are often done through Github interface)
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 30, 2020
@slorber slorber requested a review from lex111 as a code owner December 30, 2020 15:55
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 30, 2020
@netlify
Copy link

netlify bot commented Dec 30, 2020

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: 61dc4e7

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5feca303a776de0008479bc2

😎 Browse the preview: https://deploy-preview-3977--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 72
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3977--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

Size Change: 0 B

Total Size: 155 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.82 kB 0 B
website/build/main.********.js 111 kB 0 B
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@slorber slorber merged commit cf086ab into master Dec 30, 2020
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/prettier-ignore-showcase branch August 17, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
v2.0.0-alpha.71
Development

Successfully merging this pull request may close these issues.
3 participants
@slorber @lex111 @facebook-github-bot