Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): fix date-sensitive test fixture #3988

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jan 4, 2021

Motivation

Test is sensitive to current year: make it insensitive.

Porting code of @9oelM in closed PR https://github.com/facebook/docusaurus/pull/3984/files#diff-1fcecbf1a624edb15aef11f316e17b2deed40b10719340d05f208217b3c236ae

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jan 4, 2021
@slorber slorber requested a review from lex111 as a code owner January 4, 2021 15:21
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 4, 2021
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

Size Change: 0 B

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.82 kB 0 B
website/build/main.********.js 112 kB 0 B
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Jan 4, 2021

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: 66bef8a

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5ff332975c65ca0007bc4814

😎 Browse the preview: https://deploy-preview-3988--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 4, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 87
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3988--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit d2d2872 into master Jan 4, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/fix-test-date-sensitive branch August 17, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants