Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix/enhance minor i18n issues reported #4092

Merged
merged 6 commits into from
Jan 22, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jan 22, 2021

Motivation

Minor i18n fixes reported here: #3317 (comment)

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview + SEO tools

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jan 22, 2021
@slorber slorber requested a review from lex111 as a code owner January 22, 2021 18:34
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 22, 2021
@netlify
Copy link

netlify bot commented Jan 22, 2021

[V1] Deploy preview success

Built with commit f80b58d

https://deploy-preview-4092--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Jan 22, 2021

Deploy preview for docusaurus-2 ready!

Built with commit f80b58d

https://deploy-preview-4092--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4092--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

Size Change: -2 B (0%)

Total Size: 27.1 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.9 kB -1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.02 kB -1 B (0%)

compressed-size-action

@slorber slorber merged commit 869ebe7 into master Jan 22, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/i18n-review-1 branch August 17, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants