Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): ideal image assets should be served under ./assets #4166

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Feb 3, 2021

Motivation

Follow-up on #3156

We want all static assets to be in ./assets and have hashes, so that users can leverage CDN caching more easily

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 3, 2021
@slorber slorber requested a review from lex111 as a code owner February 3, 2021 14:29
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 3, 2021
@netlify
Copy link

netlify bot commented Feb 3, 2021

[V1] Deploy preview success

Built with commit ff23f38

https://deploy-preview-4166--docusaurus-1.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

Size Change: 0 B

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.7 kB 0 B
website/build/assets/js/main.********.js 109 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.94 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 3, 2021

Deploy preview for docusaurus-2 ready!

Built with commit ff23f38

https://deploy-preview-4166--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 63
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4166--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit 823d0fe into master Feb 3, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/move-ideal-image-assets branch August 17, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants