Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off react-dev-utils #4196

Closed
wants to merge 1 commit into from
Closed

Switch off react-dev-utils #4196

wants to merge 1 commit into from

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Feb 8, 2021

Signed-off-by: Reece Dunham me@rdil.rocks

Motivation

Switches the core to use a vendored version of react-dev-utils

Benefits

  • Appease the security static analysis tools (don't depend on older immer)
  • Dependency versions controlled by us
  • Less dead code (smaller dependency tree as a result!)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Works just fine in my testing

Related PRs

facebook/create-react-app#10412

Signed-off-by: Reece Dunham <me@rdil.rocks>
@RDIL RDIL requested review from lex111 and slorber as code owners February 8, 2021 18:26
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 8, 2021
@netlify
Copy link

netlify bot commented Feb 8, 2021

@netlify
Copy link

netlify bot commented Feb 8, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 2083d0d

https://deploy-preview-4196--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 8, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4196--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Feb 8, 2021

Size Change: 0 B

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 109 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.94 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Feb 9, 2021

not really willing to merge this sorry, that's a lot of code that we likely don't want to maintain ourselves

if we really can't wait for a fix in CRA with the security fix to be published (related to #4191), we'd rather publish a fork of CRA temporarily and then move back to the upstream repo once the PR is merged

@slorber slorber closed this Feb 9, 2021
@RDIL
Copy link
Contributor Author

RDIL commented Feb 9, 2021

Alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants