Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix npm/yarn command example for swizzling TypeScript theme components #4230

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

YashTotale
Copy link
Contributor

Motivation

The example was not working, because there was no extra -- in front of --typescript

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Testing is pretty simple: run the previous example on the command line which does not work as the --typescript is interpreted as part of the npm command, and run the new example with an extra -- which does work as the --typescript is interpreted as an option for the docusaurus command.

@facebook-github-bot
Copy link
Contributor

Hi @YashTotale!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Feb 17, 2021

@netlify
Copy link

netlify bot commented Feb 17, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 9b59a91

https://deploy-preview-4230--docusaurus-2.netlify.app

@github-actions
Copy link

Size Change: 0 B

Total Size: 158 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 111 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB 0 B

compressed-size-action

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 77
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4230--docusaurus-2.netlify.app/classic/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 17, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 17, 2021
@slorber slorber changed the title Fix Swizzling TypeScript theme components example docs(v2): fix npm/yarn command example for swizzling TypeScript theme components Feb 17, 2021
@slorber
Copy link
Collaborator

slorber commented Feb 17, 2021

thanks

was already fixed in upcoming release but not a bad idea to backport :)

@slorber slorber merged commit cf080c7 into facebook:master Feb 17, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants