fix(v2): avoid horizontal scrolling when long lines of code #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Deploy preview success Built with commit 9d6a696 |
|
Size Change: +8 B (0%) Total Size: 158 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built with commit 9d6a696 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4241--docusaurus-2.netlify.app/classic/ |
|
that seems to work but I think something simpler is possible: add |
|
@slorber thanks, we can really go this way. |
|
still fails for 1350px width on this page https://deploy-preview-4241--docusaurus-2.netlify.app/classic/docs/markdown-features Will edit the pr and apply this CSS to larger breakpoints as well and then merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3870
Closes #4235
Because the most correct solution in our case is to set the maximum width for the column with main content on desktop (except extra large screens).
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Check it out Using React page on preview site as per instructions in #3870.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)