chore(v2): PostCSS peer dep fix #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 468ae17 https://app.netlify.com/sites/docusaurus-1/deploys/6033cd9f0c12380007366fe4 |
|
Size Change: 0 B Total Size: 544 kB ℹ️ View Unchanged
|
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 3f95c62 https://app.netlify.com/sites/docusaurus-1/deploys/6033cdb01b44d400075c63b3 |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 468ae17 |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 3f95c62 |
slorber
added
the
pr: maintenance
|
👍 thanks |
|
was wondering if we could setup the CI to catch the yarn 2 errors? Can we make it so that it fails when there's something wrong?
|
|
I'll see if we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes the project on Yarn v2, because postcss-loader has a peer on postcss, but it isnt provided by docusaurus, only implied by postcss-preset-env, so it breaks.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Its just a lockfile change, shouldnt break anything
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)