Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): Code blocks should be LTR by default #4277

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Feb 23, 2021

Motivation

Code blocks should rather be LTR by default.

Using RTLCSS ignore directive to force the RTL style: https://rtlcss.com/learn/usage-guide/control-directives/

Not totally sure RTL code blocks make any sense, but asked a question here: shadeed/rtl-styling#13

Added the language as className in case the user wants to override this on a per-language basis

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 23, 2021
@slorber slorber requested a review from lex111 as a code owner February 23, 2021 17:32
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 23, 2021
@netlify
Copy link

netlify bot commented Feb 23, 2021

[V1] Deploy preview success

Built with commit 7528bb3

https://deploy-preview-4277--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Feb 23, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 7528bb3

https://deploy-preview-4277--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 81
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4277--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

Size Change: +43 B (0%)

Total Size: 544 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.1 kB +28 B (0%)
website/build/assets/js/main.********.js 370 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.5 kB +15 B (0%)
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.6 kB 0 B

compressed-size-action

@slorber slorber merged commit 3d00613 into master Feb 23, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/rtl-code-blocks branch August 17, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants