Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add AttoBot website to showcase page #4284

Merged
merged 6 commits into from
Feb 24, 2021

Conversation

wolf20482
Copy link
Contributor

Motivation

The official website of AttoBot is using Docusaurus v2. It can be added on the showcase page.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.

Related PRs

N/A

@facebook-github-bot
Copy link
Contributor

Hi @wolf20482!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Feb 24, 2021

@netlify
Copy link

netlify bot commented Feb 24, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit eb63011

https://deploy-preview-4284--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 24, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber changed the title Add AttoBot website to showcase page docs(v2): Add AttoBot website to showcase page Feb 24, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 24, 2021
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

need to use alphabetical order + a better site screenshot uniform to the existing ones :)

website/src/data/users.js Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 24, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 40
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4284--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Feb 24, 2021

Size Change: 0 B

Total Size: 544 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.1 kB 0 B
website/build/assets/js/main.********.js 370 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.5 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.6 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Feb 24, 2021

lgtm thanks

@slorber slorber merged commit c874304 into facebook:master Feb 24, 2021
@wolf20482 wolf20482 deleted the patch-2 branch February 24, 2021 15:02
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants