Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Fix examples by importing React #4297

Merged
merged 1 commit into from
Feb 26, 2021
Merged

docs(v2): Fix examples by importing React #4297

merged 1 commit into from
Feb 26, 2021

Conversation

roydukkey
Copy link
Contributor

Motivation

Code examples fail without import React from 'react';

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tried implementing on my project with the copied code from docs. yarn start succeeded, but served blank screen.

Related PRs

Didn't find any.

@facebook-github-bot
Copy link
Contributor

Hi @roydukkey!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Feb 26, 2021

@roydukkey
Copy link
Contributor Author

Not going to sign CLA. You're welcome to merge this or create a new PR with the same changes.

@github-actions
Copy link

Size Change: 0 B

Total Size: 532 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.1 kB 0 B
website/build/assets/js/main.********.js 359 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.4 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 26, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 90b3f9c

https://deploy-preview-4297--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4297--docusaurus-2.netlify.app/classic/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 26, 2021
@slorber slorber changed the title Fix examples by importing React docs(v2): Fix examples by importing React Feb 26, 2021
@slorber
Copy link
Collaborator

slorber commented Feb 26, 2021

Make sense thanks.

Can you please sign the CLA? (it's a FB legal requirement)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 26, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber merged commit 12afb9e into facebook:master Feb 26, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@roydukkey roydukkey deleted the patch-1 branch March 1, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants