Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): correct some of type errors reported by eslint #4382

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Mar 10, 2021

Motivation

Fix some of simpler warnings reported by eslint

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Related tickets

ref; #3424

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 10, 2021
@netlify
Copy link

netlify bot commented Mar 10, 2021

@netlify
Copy link

netlify bot commented Mar 10, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 9423941

https://deploy-preview-4382--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 10, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4382--docusaurus-2.netlify.app/classic/

@@ -51,7 +51,7 @@ export function normalizePluginOptions<T extends {id?: string}>(
logValidationBugReportHint();
if (isValidationDisabledEscapeHatch) {
console.error(error);
return options;
return options as T;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unsafe but it happens only if we want to ignore validation

@slorber
Copy link
Collaborator

slorber commented Mar 12, 2021

thanks 👍

@slorber slorber changed the title fix(v2): correct some of type errors reported by eslint refactor(v2): correct some of type errors reported by eslint Mar 12, 2021
@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 12, 2021
@slorber slorber merged commit bfe52cd into facebook:master Mar 12, 2021
@armano2 armano2 deleted the types/eslint branch March 12, 2021 15:17
@lex111 lex111 added this to the v2.0.0-alpha.72 milestone Mar 15, 2021
This was referenced Mar 17, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants