Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): Export Joi from validation-utils package #4459

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 18, 2021

Motivation

Export Joi so that plugin authors don't end up with duplicate Joi versions.

Fixes #4456

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Mar 18, 2021
@slorber slorber requested a review from lex111 as a code owner March 18, 2021 17:39
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 18, 2021
@netlify
Copy link

netlify bot commented Mar 18, 2021

[V1] Deploy preview success

Built with commit d49a2b3

https://deploy-preview-4459--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Mar 18, 2021

Deploy preview for docusaurus-2 ready!

Built with commit d49a2b3

https://deploy-preview-4459--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4459--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 575 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.2 kB 0 B
website/build/assets/js/main.********.js 401 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.8 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.7 kB 0 B

compressed-size-action

@slorber slorber merged commit 60d189a into master Mar 18, 2021
@slorber slorber deleted the slorber/joi-export branch August 17, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to let plugins use a compatible version of Joi
2 participants