Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fixed broken link in i18n-tutorial.md #4558

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

idontknowjs
Copy link
Contributor

Motivation

Fixed broken link in i18n-tutorial.md
In Translate JSON Files section.

Run the write-translations redirects to https://docusaurus.io/docs/cli#docusaurus-write-translations, which is broken
Instead it should redirect to https://docusaurus.io/docs/cli#docusaurus-write-translations-sitedir

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 2, 2021
@netlify
Copy link

netlify bot commented Apr 2, 2021

@github-actions
Copy link

github-actions bot commented Apr 2, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 77
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4558--docusaurus-2.netlify.app/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 5, 2021
@slorber
Copy link
Collaborator

slorber commented Apr 5, 2021

👍

@slorber slorber merged commit 4a219f1 into facebook:master Apr 5, 2021
@idontknowjs idontknowjs deleted the patch-1 branch April 5, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants