Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): i18n perf issue: getTranslationFile() should not load content again #4593

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Apr 9, 2021

Motivation

i18n perf: the docs plugin read twice the markdown files, because it tries to load content again when trying to retrieve translation files to use.

Before, reloading the content that has already been loaded:

    async getTranslationFiles() {
      return getLoadedContentTranslationFiles(await this.loadContent());
    },

After: reusing the content that has already been loaded:

    async getTranslationFiles({content}) {
      return getLoadedContentTranslationFiles(content);
    },

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Not sure how. It's hard to prevent a plugin author to call this.loadContent() anywhere and have a perf issue, including maintainers in core plugins. It's not performant but it works.

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Apr 9, 2021
@slorber slorber requested a review from lex111 as a code owner April 9, 2021 17:06
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 9, 2021
@netlify
Copy link

netlify bot commented Apr 9, 2021

[V1]

Built with commit 4b27a03

https://deploy-preview-4593--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Apr 9, 2021

[V2]

Built with commit 4b27a03

https://deploy-preview-4593--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 63
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4593--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

Size Change: 0 B

Total Size: 576 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.2 kB 0 B
website/build/assets/js/main.********.js 401 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 61.1 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 26.1 kB 0 B

compressed-size-action

@slorber slorber merged commit cb403af into master Apr 9, 2021
@slorber slorber deleted the slorber/i18n-perf-issue branch August 17, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants