Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add "PptxGenJS" to showcase #4602

Merged
merged 5 commits into from
Apr 13, 2021
Merged

Conversation

gitbrent
Copy link
Contributor

Motivation

Adding new site to showcase.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.

Related PRs

No

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 12, 2021
@netlify
Copy link

netlify bot commented Apr 12, 2021

@github-actions
Copy link

github-actions bot commented Apr 12, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 70
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4602--docusaurus-2.netlify.app/

website/src/data/users.js Outdated Show resolved Hide resolved
website/src/data/users.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, almost LGTM, just the source is targeting the gh-pages deployment in place of your site's source code

description: 'PowerPoint JavaScript Library',
preview: require('./showcase/pptxgenjs.png'),
website: 'https://gitbrent.github.io/PptxGenJS/',
source: 'https://github.com/gitbrent/PptxGenJS/tree/gh-pages',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this source url to the repo where the Docusaurus site sources are? (I mean, not the built HTML files)

@netlify
Copy link

netlify bot commented Apr 12, 2021

[V1]

Built with commit d0fed96

https://deploy-preview-4602--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Apr 12, 2021

[V1]

Built with commit 0bf30ba

https://deploy-preview-4602--docusaurus-1.netlify.app

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 13, 2021
@slorber slorber changed the title Add "PptxGenJS" to showcase docs(v2): Add "PptxGenJS" to showcase Apr 13, 2021
@slorber slorber merged commit 7ba0fdf into facebook:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants