Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): toggleResponsiveSidebar => more stable callback #4626

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Apr 16, 2021

Motivation

The toggle callback does not need to change (trigger useless sidebar re-renders) and can use the functional setState form

@slorber slorber added pr: polish This PR adds a very minor behavior improvement that users will enjoy. pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient. labels Apr 16, 2021
@slorber slorber requested a review from lex111 as a code owner April 16, 2021 08:06
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 16, 2021
@netlify
Copy link

netlify bot commented Apr 16, 2021

[V1]

Built with commit 9f0a6cc

https://deploy-preview-4626--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Apr 16, 2021

[V2]

Built with commit 9f0a6cc

https://deploy-preview-4626--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 54
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4626--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 599 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.2 kB 0 B
website/build/assets/js/main.********.js 422 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.1 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 26.9 kB 0 B

compressed-size-action

@slorber slorber merged commit 38a1003 into master Apr 16, 2021
@slorber slorber deleted the slorber/make-sidebar-callback-more-stable branch August 17, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient. pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants