Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): specify google-analytics and gtag plugins #4703

Merged
merged 1 commit into from
May 4, 2021
Merged

docs(v2): specify google-analytics and gtag plugins #4703

merged 1 commit into from
May 4, 2021

Conversation

yiliansource
Copy link
Contributor

Motivation

As noted in #4678 it was hard to notice that the google-analytics-related plugins were only able in production builds. Notes that clarify this have been added, following the style of the ideal-image plugin. Additionally, a common misconception between Tracking IDs (UA-) and Measurement IDs (G-) has been explained, and Google's Tag Assistant has been linked to aid developers in debugging.

Have you read the Contributing Guidelines on pull requests?

Yes.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 29, 2021
@netlify
Copy link

netlify bot commented Apr 29, 2021

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 76
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4703--docusaurus-2.netlify.app/

@slorber slorber changed the title docs: specify google-analytics and gtag plugins docs(v2): specify google-analytics and gtag plugins May 4, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label May 4, 2021
@slorber
Copy link
Collaborator

slorber commented May 4, 2021

Thanks, that looks like useful doc additions ;)

@slorber slorber merged commit 5fc5071 into facebook:master May 4, 2021
@yiliansource yiliansource deleted the yiliansource/google-plugin-addendum branch May 5, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants