Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add tinaeldevresse.eu to Docusaurus' gallery #4786

Merged
merged 3 commits into from
May 14, 2021
Merged

docs(v2): Add tinaeldevresse.eu to Docusaurus' gallery #4786

merged 3 commits into from
May 14, 2021

Conversation

HunteRoi
Copy link
Contributor

Motivation

Just willing to add my personal blog to your gallery 😄

Have you read the Contributing Guidelines on pull requests?

Yes!

Test Plan

N/A

Related PRs

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 13, 2021
@netlify
Copy link

netlify bot commented May 13, 2021

[V2]

Built with commit 9e60c80

https://deploy-preview-4786--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented May 13, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4786--docusaurus-2.netlify.app/

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just changing a few details

website/src/data/users.js Outdated Show resolved Hide resolved
website/src/data/users.js Outdated Show resolved Hide resolved
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label May 14, 2021
@slorber slorber changed the title Add tinaeldevresse.eu to Docusaurus' gallery docs(v2): Add tinaeldevresse.eu to Docusaurus' gallery May 14, 2021
@netlify
Copy link

netlify bot commented May 14, 2021

[V1]

Built with commit 00bddce

https://deploy-preview-4786--docusaurus-1.netlify.app

@slorber slorber merged commit b33ee82 into facebook:master May 14, 2021
@netlify
Copy link

netlify bot commented May 14, 2021

[V1]

Built with commit 9e60c80

https://deploy-preview-4786--docusaurus-1.netlify.app

@HunteRoi
Copy link
Contributor Author

Just saw you removed the i18n tag although I am currently translating everything. Would you mind if I add it back once I have pushed the i18n feature from v2.0.0-beta.0 ? @slorber

@slorber
Copy link
Collaborator

slorber commented May 16, 2021

sure no problem, just don't want to have tags that are not yet visible in your site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants