Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add mr-pdf to resources #4818

Merged
merged 2 commits into from
May 25, 2021
Merged

Conversation

antonygibbs
Copy link
Contributor

Added new option for PDF generation seeing as docusaurus-pdf doesn't work beyond 2.0.0.-alpha73, as establised in bug #29.

Motivation

(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Added new option for PDF generation seeing as docusaurus-pdf doesn't work beyond 2.0.0.-alpha73, as establised in [bug facebook#29](kohheepeace/docusaurus-pdf#29).
@facebook-github-bot
Copy link
Contributor

Hi @antonygibbs!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented May 19, 2021

@github-actions
Copy link

github-actions bot commented May 19, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 59
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4818--docusaurus-2.netlify.app/

@slorber slorber changed the title Update 2-resources.md docs(v2): add mr-pdg to resources May 20, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label May 20, 2021
@slorber
Copy link
Collaborator

slorber commented May 20, 2021

Thanks, that looks nice

We need you to sign the FB CLA otherwise I technically can't merge this PR

@netlify
Copy link

netlify bot commented May 20, 2021

[V1]

Built with commit 59a30ce

https://deploy-preview-4818--docusaurus-1.netlify.app

@antonygibbs
Copy link
Contributor Author

Sorry, I missed the bit on CLA. I have signed this now.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 20, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111
Copy link
Contributor

lex111 commented May 21, 2021

@kohheepeace maybe we should remove the link to docusaurus-pdf at all, if there is better alternative as mr-pdf?

@kohheepeace
Copy link
Contributor

kohheepeace commented May 25, 2021

@lex111 Hi, mr-pdf is not for docusaurus only. So, I think only docusaurus-pdf is listed. But I need to update docusaurus-pdf for v2 beta. The bad things is that I can't say when it will be. So, removing from the list is also ok.

@lex111
Copy link
Contributor

lex111 commented May 25, 2021

@kohheepeace no worries, I think we only to list mr-pdf, which can work with any version of Docusaurus.

@lex111 lex111 changed the title docs(v2): add mr-pdg to resources docs(v2): add mr-pdf to resources May 25, 2021
@lex111 lex111 merged commit 36b91a9 into facebook:master May 25, 2021
@lex111
Copy link
Contributor

lex111 commented May 25, 2021

@antonygibbs thanks for update!

@antonygibbs antonygibbs deleted the patch-1 branch May 25, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants